Fix typo: the past tense of shutdown is shutdown, not shutdowned by GabrielBrascher · Pull Request #3659 · apache/cloudstack

GabrielBrascher · 2019-11-01T02:04:03Z

Description

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

yadvr · 2019-11-06T18:10:29Z

        Error(false, "VM is in error"),
        Unknown(false, "VM state is unknown."),
-        Shutdowned(false, "VM is shutdowned from inside");
+        Shutdown(false, "VM is shutdown from inside");


@GabrielBrascher Add database upgrade path to update any VMs in the old state to the new state name. (just a rare edge case).

@rhtyd added a database upgrade schema from 4.13.0.0 to 4.13.1.0 upgrading VMs from state Shutdowned to Shutdown.

@rhtyd does it look like a 4.13.1 fix? I had mapped it to 4.13.1.0, but I can target it to master/4.14.0.0; not really a bug fix, more likely an enhancement.

wido

Code LGTM

GabrielBrascher · 2019-11-27T15:10:27Z

@blueorangutan package

blueorangutan · 2019-11-27T15:10:42Z

@GabrielBrascher a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2019-11-27T15:31:31Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-397

DaanHoogland

I do approve of this change with one caveat:
If the state is used in automation by parsing logs or alerts this automation will break. I would like to see a small upgrade guide entry for that.

GabrielBrascher · 2019-11-28T13:12:48Z

@DaanHoogland Makes sense adding it to the upgrade guide.

GabrielBrascher · 2019-12-04T23:41:49Z

@rhtyd are you ok with this PR? Database upgrade has been covered.

yadvr · 2019-12-05T08:35:22Z

Hi @GabrielBrascher let me review this and get back to you soon

yadvr · 2019-12-07T22:29:15Z

This could be considered major change @GabrielBrascher - can you move this to 4.13->4.14 upgrade path on master?

GabrielBrascher · 2019-12-09T16:58:59Z

No problem @rhtyd, I will move it to 4.14

GabrielBrascher · 2019-12-10T01:08:19Z

@rhtyd code has been updated, ported to master and added SQL UPDATE into schema-41300to41400.sql.

GabrielBrascher · 2019-12-12T13:41:40Z

Fixed conflict on schema-41300to41400.sql; now the branch has no conflicts with the master branch.

GabrielBrascher · 2020-01-03T14:21:51Z

@andrijapanicsb this one looks like a simple "fix" and has 2 LGTMs aiming it for 4.14. Can you please take a look?

@rhtyd thanks for the review, are you ok with the code the way that it is after updating the upgrade path?

andrijapanicsb · 2020-01-03T14:27:48Z

Looks OK @GabrielBrascher and the schema update path as well.

andrijapanicsb · 2020-01-03T14:28:03Z

@blueorangutan package

blueorangutan · 2020-01-03T14:28:25Z

@andrijapanicsb a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2020-01-03T15:08:17Z

Packaging result: ✖centos6 ✔centos7 ✔debian. JID-525

andrijapanicsb · 2020-01-03T21:45:08Z

@blueorangutan test

blueorangutan · 2020-01-03T21:45:27Z

@andrijapanicsb a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

andrijapanicsb · 2020-01-04T15:55:24Z

@blueorangutan test

blueorangutan · 2020-01-04T15:55:30Z

@andrijapanicsb a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2020-01-05T00:20:38Z

Trillian test result (tid-693)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 28374 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3659-t693-kvm-centos7.zip
Smoke tests completed. 77 look OK, 0 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File

andrijapanicsb · 2020-01-13T22:39:25Z

Let there be grammar!

…che#3659)

GabrielBrascher added the component:UI label Nov 1, 2019

GabrielBrascher added this to the 4.13.1.0 milestone Nov 1, 2019

GabrielBrascher requested a review from borisstoyanov November 1, 2019 02:04

GabrielBrascher self-assigned this Nov 1, 2019

GabrielBrascher force-pushed the typo-fix-shutdowned branch from 7625f5b to 3262fbc Compare November 1, 2019 02:28

svenvogel added the type:enhancement label Nov 1, 2019

yadvr reviewed Nov 6, 2019

View reviewed changes

GabrielBrascher force-pushed the typo-fix-shutdowned branch 4 times, most recently from df067a3 to 9e2fa49 Compare November 14, 2019 13:18

GabrielBrascher requested review from andrijapanicsb, wido and yadvr November 21, 2019 15:12

wido approved these changes Nov 22, 2019

View reviewed changes

GabrielBrascher requested review from DaanHoogland and svenvogel November 27, 2019 04:09

DaanHoogland approved these changes Nov 28, 2019

View reviewed changes

yadvr changed the base branch from 4.13 to master December 7, 2019 22:28

yadvr modified the milestones: 4.13.1.0, 4.14.0.0 Dec 7, 2019

GabrielBrascher force-pushed the typo-fix-shutdowned branch from 9e2fa49 to 5db61c0 Compare December 10, 2019 01:03

Fix typo: the past tense of shutdown is shutdown, not shutdowned

72b42ae

GabrielBrascher force-pushed the typo-fix-shutdowned branch from 5db61c0 to 72b42ae Compare December 10, 2019 01:05

Merge branch 'master' into typo-fix-shutdowned

fb48d07

andrijapanicsb approved these changes Jan 3, 2020

View reviewed changes

andrijapanicsb merged commit d8a2f5d into apache:master Jan 13, 2020

apache deleted a comment from blueorangutan Jan 13, 2020

Spaceman1984 pushed a commit to shapeblue/cloudstack that referenced this pull request Jan 17, 2020

Fix typo: the past tense of shutdown is shutdown, not shutdowned (apa…

08373af

…che#3659)

Hossein4185 mentioned this pull request Aug 5, 2023

Upgrade Cloudstack 4.13.1 to 4.17.2 #7820

Closed

Conversation

GabrielBrascher commented Nov 1, 2019 • edited by DaanHoogland Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Uh oh!

yadvr Nov 6, 2019

Choose a reason for hiding this comment

Uh oh!

GabrielBrascher Nov 12, 2019

Choose a reason for hiding this comment

Uh oh!

GabrielBrascher Nov 14, 2019

Choose a reason for hiding this comment

Uh oh!

wido left a comment

Choose a reason for hiding this comment

Uh oh!

GabrielBrascher commented Nov 27, 2019

Uh oh!

blueorangutan commented Nov 27, 2019

Uh oh!

blueorangutan commented Nov 27, 2019

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

GabrielBrascher commented Nov 28, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

GabrielBrascher commented Dec 4, 2019

Uh oh!

yadvr commented Dec 5, 2019

Uh oh!

yadvr commented Dec 7, 2019

Uh oh!

GabrielBrascher commented Dec 9, 2019

Uh oh!

GabrielBrascher commented Dec 10, 2019

Uh oh!

GabrielBrascher commented Dec 12, 2019

Uh oh!

GabrielBrascher commented Jan 3, 2020

Uh oh!

andrijapanicsb commented Jan 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

andrijapanicsb commented Jan 3, 2020

Uh oh!

blueorangutan commented Jan 3, 2020

Uh oh!

blueorangutan commented Jan 3, 2020

Uh oh!

andrijapanicsb commented Jan 3, 2020

Uh oh!

blueorangutan commented Jan 3, 2020

Uh oh!

andrijapanicsb commented Jan 4, 2020

Uh oh!

blueorangutan commented Jan 4, 2020

Uh oh!

blueorangutan commented Jan 5, 2020

Uh oh!

andrijapanicsb commented Jan 13, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

GabrielBrascher commented Nov 1, 2019 •

edited by DaanHoogland

Loading

GabrielBrascher commented Nov 28, 2019 •

edited

Loading

andrijapanicsb commented Jan 3, 2020 •

edited

Loading